-
Notifications
You must be signed in to change notification settings - Fork 127
Fix apps-mcp agent behavior: localhost preference and deployment conf… #4056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irmation Two key issues addressed: 1. Agent was opening deployed URLs instead of localhost when user asked to "open a dev copy" or see the app during development. 2. Agent was deploying too early without user confirmation. Changes: - apps.tmpl: Add localhost guidance and deployment confirmation requirement - CLAUDE.md: Add "Deployment Procedures" section with pre-deployment checklist - CLAUDE.md: Add "Local Development vs Deployed Apps" section with decision tree The agent will now: - Prefer localhost:8000 during active development - Ask "Ready to deploy to [environment]?" before deploying - Only use deployed URLs after deployment with user approval Addresses feedback from PR #4045 discussion.
Contributor
|
FYI the |
…rmation Three key issues addressed: 1. Agent was opening deployed URLs instead of localhost when user asked to "open a dev copy" or see the app during development. 2. Agent was deploying too early without user confirmation. 3. Need to clarify npm run dev (development) vs npm start (production). Changes: - apps.tmpl: Add localhost guidance and deployment confirmation requirement - apps.tmpl: Clarify "npm run dev" ALWAYS for development, NEVER "npm start" - CLAUDE.md: Add "Deployment Procedures" section with pre-deployment checklist - CLAUDE.md: Add "Local Development vs Deployed Apps" section with decision tree - CLAUDE.md: Add visual box explaining "npm run dev vs npm start" The agent will now: - ALWAYS use "npm run dev" during development (NEVER npm start) - Prefer localhost:8000 during active development - Ask "Ready to deploy to [environment]?" before deploying - Only use deployed URLs after deployment with user approval Addresses feedback from PR #4045 discussion.
Collaborator
|
Commit: 971ef02
30 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
fjakobs
approved these changes
Dec 2, 2025
apps.tmpl is now stack-agnostic and focused only on MCP workflow: - init-template command - Validation workflow - Deployment confirmation - References CLAUDE.md for template-specific details CLAUDE.md retains all template-specific guidance: - npm run dev vs npm start - localhost vs deployed URLs - Deployment procedures with checklist - TypeScript, testing, and other stack-specific details This removes duplication and properly separates concerns.
Remove template-specific details (npm, SQL, tRPC, UI components) that came from merge. Keep only MCP workflow commands and reference CLAUDE.md for template-specific guidance. Maintains: - init-template → cd → read CLAUDE.md workflow - Validation command - Deployment confirmation requirement
Restore the step-by-step guidance that was accidentally removed. This provides clearer structure for agents building apps.
Remove all branch-specific changes to apps.tmpl, keeping only the version from main branch.
arsenyinfo
approved these changes
Dec 2, 2025
Contributor
|
Merging manually. The checks marked as required are not required anymore and won't run. This is a transient issue and should self-resolve. |
Collaborator
|
Commit: ed2e6d4
44 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix apps-mcp agent behavior: localhost preference and deployment confirmation
Two key issues addressed:
Agent was opening deployed URLs instead of localhost when user asked to "open a dev copy" or see the app during development.
Agent was deploying too early without user confirmation.
Changes:
The agent will now:
Addresses feedback from PR #4045 discussion.
Changes
Prompt updates with checklist how to deploy when and how to run app.
Why
issue 21 | Victor | The deployment was really early, maybe a confirmation step first.
issue 30 | Lennart | Agent is opening deployed apps rather than “dev copy” (unless I ask about localhost very explicitly)
Tests
make test